Minetest logo

IRC log for #minetest-dev, 2017-08-12

| Channels | #minetest-dev index | Today | | Google Search | Plaintext

All times shown according to UTC.

Time Nick Message
00:55 ssieb joined #minetest-dev
02:26 bigfoot547 joined #minetest-dev
02:27 YuGiOhJCJ joined #minetest-dev
06:49 Hunterz joined #minetest-dev
07:48 Taoki[laptop] joined #minetest-dev
08:00 paramat joined #minetest-dev
08:10 paramat stuff to do!
08:11 VanessaE this oughta be good. :)
09:14 paramat sofar https://github.com/minetes​t/minetest_game/pull/1835 ? and https://github.com/minetes​t/minetest_game/pull/1813 for consideration
09:17 ^v joined #minetest-dev
09:31 karamel joined #minetest-dev
09:57 jas_ paramat: 140+ uses of 'color' ... does tenplus11 expect those to be changed too?!  also can i have +v in hub
10:00 paramat yeah
10:24 Krock joined #minetest-dev
10:34 Player_2 joined #minetest-dev
10:43 DI3HARD139 joined #minetest-dev
10:51 Fixer joined #minetest-dev
10:56 Fixer_ joined #minetest-dev
11:24 red-001 huh I though we were using the American spelling of colour?
11:24 paramat heh we are
11:25 paramat only because that's the majority though :]
11:42 celeron55 i should've never allowed any native english speakers to the core team; they just start to fight about things like this
11:45 celeron55 i would like US english to be used because it seems to usually be more straightforward
11:46 celeron55 (if you're a brit or american, you can't have a say because you're biased :P)
11:48 red-001 it only matters for API functions anyway
11:51 lisac joined #minetest-dev
12:06 paramat celeron55 i checked, see results that support your wish https://github.com/minetest/minetest/issues/6238
12:08 celeron55 red-001: that is true
12:10 paramat it helps devs and contributors too to know which to use, and is nicely consistent
12:39 paramat joined #minetest-dev
12:48 DI3HARD139 joined #minetest-dev
14:49 tenplus1 joined #minetest-dev
14:49 tenplus1 changes made:  game#1844
14:49 ShadowBot https://github.com/minetest​/minetest_game/issues/1844 -- TNT: add explode_middle flag by tenplus1
14:49 tenplus1 left #minetest-dev
15:30 rubenwardy https://forum.minetest.net/viewtopic.php​?f=6&t=18285&view=unread#unread
15:30 rubenwardy English English is obviously the best english 8D
15:31 rubenwardy For code, we should use American English
15:31 rubenwardy For comments, I couldn't care less
15:34 rubenwardy but please please please can we avoid idioms like "could care less"
15:34 rubenwardy and "PBJ"
16:15 Krock are there any specialities from Australia we should consider? :P
16:23 paramat joined #minetest-dev
16:35 paramat #6238 can we agree to use USA English in code? if so please can someone add this to the dev wiki code style guidelines?
16:35 ShadowBot https://github.com/minetest/minetest/issues/6238 -- Require USA English in code style guidelines
17:24 paramat thanks, bbl for meeting
17:40 torgdor joined #minetest-dev
17:51 Noxarivis[m] joined #minetest-dev
18:00 paramat joined #minetest-dev
18:01 Robby- joined #minetest-dev
18:03 est31 joined #minetest-dev
18:05 paramat hmm SN not around. nore rubenwardy sfan5 sofar celeron55 anything you want to discuss?
18:13 rubenwardy Paramat, a few thing
18:14 rubenwardy One sec (turning on computer)
18:16 rubenwardy it would be nice to have a mega PR review session
18:17 rubenwardy well, to at least reduce the number of open PRs
18:19 rubenwardy Firstly: I'd like to introduce unit tests for builtin
18:19 rubenwardy however there's the issue of the API being tied to the rest of the project
18:21 rubenwardy so we'd need to start a server to run the tests, although it would exit after the tests run after loading
18:21 silwol joined #minetest-dev
18:26 rubenwardy merging #4258 in ten minutes
18:26 ShadowBot https://github.com/minetest/minetest/issues/4258 -- Abort if static_spawnpoint is an invalid setting instead of just giving an error log by HybridDog
18:27 paramat yeah there are some things to merge, are you able to merge #6231 at the same time?
18:27 ShadowBot https://github.com/minetest/minetest/issues/6231 -- Mgv5: Make spawn position search more reliable by paramat
18:28 rubenwardy sure
18:28 paramat oh and #6202
18:28 ShadowBot https://github.com/minetest/minetest/issues/6202 -- Remove cloud_height setting by bendeutsch
18:28 sfan5 i think there might be one or two more prs with >= 2 approvals
18:28 paramat 6202 needs squash
18:29 paramat #6230 is simple, needs another +1
18:29 ShadowBot https://github.com/minetest/minetest/issues/6230 -- Full viewing range key message clarified by Fixer-007
18:30 paramat ah #6232 can be merged
18:30 ShadowBot https://github.com/minetest/minetest/issues/6232 -- Trigger on_rightclick regardless on the formspec meta field by SmallJoker
18:32 rubenwardy hmmm
18:32 rubenwardy how likely is it for a mod to rely on the behaviour pre #6232
18:32 ShadowBot https://github.com/minetest/minetest/issues/6232 -- Trigger on_rightclick regardless on the formspec meta field by SmallJoker
18:33 rubenwardy view range sounds weird to me
18:33 paramat 'viewing' is ok for me too
18:33 rubenwardy both are probably correct
18:34 rubenwardy nah, view range is probably better
18:34 rubenwardy it doesn't matter much
18:35 paramat 'viewing range' just sounds a little awkward to me
18:35 paramat nice
18:36 lisac joined #minetest-dev
18:36 rubenwardy okay, I'm ready to merge #4258 #6202 #6230
18:36 ShadowBot https://github.com/minetest/minetest/issues/4258 -- Abort if static_spawnpoint is an invalid setting instead of just giving an error log by HybridDog
18:36 ShadowBot https://github.com/minetest/minetest/issues/6202 -- Remove cloud_height setting by bendeutsch
18:36 ShadowBot https://github.com/minetest/minetest/issues/6230 -- Full viewing range key message clarified by Fixer-007
18:37 paramat and #6231 ?
18:37 ShadowBot https://github.com/minetest/minetest/issues/6231 -- Mgv5: Make spawn position search more reliable by paramat
18:37 rubenwardy oh yeah, that too
18:38 paramat all fine for me
18:38 rubenwardy ok, merging...
18:41 rubenwardy so, what should we do with very old pull requests?
18:41 rubenwardy typically out of date with an author that has quit, and is only kept open for documentation reasons
18:43 paramat sometimes i go through and poke them, maybe find a few that can be closed. there is the 1 month no response thing too
18:44 rubenwardy yeah
18:44 rubenwardy can we close #1489?
18:44 ShadowBot https://github.com/minetest/minetest/issues/1489 -- Timed move by sapier
18:45 rubenwardy it would be quite nice to get below 100 PRs before the end of the month
18:46 rubenwardy although need to avoid letting this be an excuse to reject loads
18:46 paramat 2 devs are not keen on that PR, needs rebase, author not around, i'm ok with a close, sfan5?
18:46 sfan5 sounds good to me
18:47 paramat #1988 ?
18:47 ShadowBot https://github.com/minetest/minetest/issues/1988 -- Fix #1374 by adding a listpredict piece to the formspec by MinerDad7
18:48 paramat oh that is rebased in #3801
18:48 ShadowBot https://github.com/minetest/minetest/issues/3801 -- Predict inventory list movement and add list_predict to formspec by sofar
18:48 paramat ah which was closed
18:49 rubenwardy looks like the PR isn't that great
18:50 paramat sofar doesn't like it
18:50 rubenwardy related issue #1374
18:50 ShadowBot https://github.com/minetest/minetest/issues/1374 -- Prediction for changes in meta inventories
18:51 paramat at least we have the issue open, so a close is ok for me
18:51 rubenwardy agreed
18:52 rubenwardy I've saved the patch
18:52 rubenwardy just incase the branch is deleted
18:55 paramat added 'adoption needed' to #3325
18:55 ShadowBot https://github.com/minetest/minetest/issues/3325 -- Append Lua backtrace to C++ exceptions when using regular Lua instead of LuaJIT by celeron55
18:56 rubenwardy seems useful
19:02 Noxarivis[m] left #minetest-dev
19:02 paramat i'll look at #3696 again
19:03 ShadowBot https://github.com/minetest/minetest/issues/3696 -- Change the settings interface for noise_params, v3f and flags by Gael-de-Sailly
19:03 rubenwardy so, #3326 and #4425
19:03 ShadowBot https://github.com/minetest/minetest/issues/3326 -- Check that LuaEntitySAO::setVelocity's parameter and generally Lua's v3f inputs are not NaN by celeron55
19:03 ShadowBot https://github.com/minetest/minetest/issues/4425 -- Assertion failure: sanitize some values obtained from mods (yaw, velocity, etc.) by Rogier-5
19:04 rubenwardy were any other PRs merged to validate Lua positions?
19:06 paramat not sure, there seems to have been many issues though
19:07 Fixer joined #minetest-dev
19:08 paramat hmm #3739 i feel like 'don't bother'
19:08 ShadowBot https://github.com/minetest/minetest/issues/3739 -- Add support for Mumble positional audio by ShadowNinja
19:09 rubenwardy I don't think that's worth dev time as a feature
19:09 rubenwardy unless a particular dev really wants it
19:09 paramat i'll comment and we can discuss with SN
19:10 paramat SN has lots of old unfinished PRs scattered around :]
19:10 rubenwardy it also seems to be half done
19:11 paramat ShadowNinja please could you reconsider your old unfinished PRs and maybe choose some to close?
19:11 paramat .. and finish the others :]
19:12 rubenwardy #5176
19:12 ShadowBot https://github.com/minetest/minetest/issues/5176 -- Use JSON serialize to store ItemStack Metadata by rubenwardy
19:12 rubenwardy I need to test that the removal of JSONSerialize or whatever doesn't break the inventory serialization
19:12 rubenwardy and other tests generally
19:13 rubenwardy the serialization of a single meta data is unit tested, just not integration generallly
19:16 paramat ok, i don't understand that stuff :]
19:17 paramat closing #4195 no response
19:17 ShadowBot https://github.com/minetest/minetest/issues/4195 -- Horizon/sky colour jitter at sunset/sunrise, Sun render glitches at sunrise
19:17 rubenwardy fair
19:17 rubenwardy Fixer: if you can find it again, let us know :)
19:17 paramat no-one else seems to have reproduced it
19:19 rubenwardy there's been quite a few people expression their concerns about the engine becoming slower and less stable
19:19 rubenwardy I wonder how we can tackle this
19:19 est31 left #minetest-dev
19:19 paramat slower really? we have made many optimisations recently
19:19 rubenwardy apart from obtaining a cloning device to replicate Fixer, that is
19:21 rubenwardy also, can we please not make debug require a permission
19:21 rubenwardy position and wire frame sure, but not the graphs etc
19:21 paramat #3492 can i close?
19:21 ShadowBot https://github.com/minetest/minetest/issues/3492 -- Terminal interface (ncurses --terminal) not updating dimensions.
19:22 paramat hm i just did
19:22 rubenwardy huh
19:22 rubenwardy I'm now getting 30 FPS, down from 60 FPS on Minetest
19:23 paramat ok i agree with no priv for profiler graphs
19:27 paramat #1315 i think now sneak places the player on the highest nodebox instead of hovering at a node border, so can be closed i think, also ancient issue
19:27 ShadowBot https://github.com/minetest/minetest/issues/1315 -- No damage_per_second while sneaking on top of the node
19:29 D33P-B00K joined #minetest-dev
19:29 paramat closed
19:29 paramat #6049 is pointless and inconvenient for dev work, any comments?
19:29 ShadowBot https://github.com/minetest/minetest/issues/6049 -- noclip: Avoid pointing the node which contains the camera position
19:30 rubenwardy really it should avoid going into a node to begin with
19:30 rubenwardy it being the camera
19:30 D33P-B00K left #minetest-dev
19:30 rubenwardy approved #6237
19:30 ShadowBot https://github.com/minetest/minetest/issues/6237 -- Add slippery group for nodes (players/items slide) (take 3) by Wuzzy2
19:31 rubenwardy it's still worth fixing the style though
19:31 rubenwardy I feel like we do focus way too much on code style, it should be the last thing really
19:31 rubenwardy in that case it is
19:31 rubenwardy I mean, I'm slightly hypocritical
19:32 paramat no 6049 is when noclip is on, then you want the camera to pass through nodes
19:32 rubenwardy ah
19:32 rubenwardy hmmm
19:33 rubenwardy -1 then
19:33 paramat and #5442, author has left MT, seems no support for FFI, any comments?
19:33 ShadowBot https://github.com/minetest/minetest/issues/5442 -- Implement FFI to LuaJIT
19:35 paramat LuaJIT has serious issues anyway, is it worth it?
19:35 rubenwardy LuaJit is used by a lot of servers
19:35 rubenwardy and really we should fix those problems
19:35 paramat that is, memory limit, causing OOM, not sure if LuaJIT is maintained anymore etc.
19:35 rubenwardy shame that we don't have any purely Lua experts
19:36 rubenwardy the new version of LuaJIT increases the memory limit to multiple GBs
19:36 paramat ah
19:38 Fixer wat?
19:38 sfan5 the memory limit of the "normal" luajit is already 2GB
19:38 sfan5 with a special twist: allocated memory need to have an address < 2GB
19:38 rubenwardy that is quite high already imo. I feel like we're doing something quite wrong
19:38 rubenwardy oh
19:38 sfan5 not necessarily
19:39 paramat lua tables created by perlin noise and lua voxelmanip are big, and don't get cleaned up quickly by GC
19:39 sfan5 sometimes lua oom is reported while only roughly 100 MB are actualy in use by lua
19:40 paramat many people have not applied the memory use optimisations i have described in the news forum
19:40 paramat .. for lvm and perlinmaps
19:41 celeron55_ joined #minetest-dev
19:42 celeron5- joined #minetest-dev
19:51 celeron55 joined #minetest-dev
19:52 Fixer update on https://github.com/minetest/minetest​/issues/4195#issuecomment-322002184
19:54 Fixer try again reproducing it, turn your lights off to see better
19:55 Fixer luajit is maintained
19:55 Fixer there is progress
19:55 paramat ok good
19:56 Fixer try reproducing 4195 again, turn off your room lights
19:56 paramat you mean 'sunrisebg.png' texture issues?
19:57 Fixer sun texture itself
19:57 Fixer feels like it is z-fighting with background
19:57 Fixer below horizon
19:58 paramat yeah i can see it in the screenshot now
20:00 jcalve joined #minetest-dev
20:05 rubenwardy <+rubenwardy> huh
20:05 rubenwardy <+rubenwardy> apparently Minetest has 10% code coverage by line
20:05 rubenwardy <+rubenwardy> thought it would be less
20:05 rubenwardy <+rubenwardy> #6240
20:05 ShadowBot https://github.com/minetest/minetest/issues/6240 -- Add unit test coverage generation by rubenwardy
20:05 rubenwardy bnc disconnected :(
20:05 rubenwardy well, I disconnected from my BNC
20:07 paramat sun has full alpha, as does the 'farcloudyfogthing'
20:09 Fixer it feels very much like z-fighting to me or/and blinking
20:09 Fixer i've renamed the issue to better name
20:10 paramat ah but sun alters alpha when it is drawn
20:10 Fixer not everyone can see that problem, you have to actually sit in a dark room to notice it
20:13 bigfoot547 joined #minetest-dev
20:17 paramat the farcloudyfogthing is drawn twice for E, W directions, maybe i'll try avoiding that double draw
20:17 rubenwardy please can we lock the modding questions topic, and encourage people to make individual topics?
20:17 rubenwardy It makes it considerably easier for people to find the answer to their questions
20:17 paramat hm good point
20:19 paramat i'm ok with that, but not my mapgen questions thread, not yet anyway
20:19 rubenwardy that's probably small enough
20:20 rubenwardy -> #hub
20:27 YuGiOhJCJ joined #minetest-dev
20:35 CalebDavis joined #minetest-dev
20:35 rubenwardy #3513 looks pretty trivial
20:35 ShadowBot https://github.com/minetest/minetest/issues/3513 -- Check item_drop amount clientside by BlockMen
20:35 rubenwardy although shift needs testing
20:57 rubenwardy #6242
20:57 ShadowBot https://github.com/minetest/minetest/issues/6242 -- Check item_drop amount clientside by rubenwardy
20:57 rubenwardy checking the player's shift like that was a hack imo and makes the modding API weird
21:44 lisac joined #minetest-dev
22:32 rubenwardy I kinda want to suggest including https://mirven.github.io/underscore.lua/
22:32 rubenwardy but it's quite likely that a mod would abuse it
22:32 rubenwardy ie: use it in performance critical areas
23:06 rubenwardy #6243
23:06 ShadowBot https://github.com/minetest/minetest/issues/6243 -- Load dependencies and description from mod.conf by rubenwardy
23:47 silwol joined #minetest-dev
23:48 rubenwardy #6244
23:48 ShadowBot https://github.com/minetest/minetest/issues/6244 -- Change README to Markdown format, add LICENSE.txt by rubenwardy

| Channels | #minetest-dev index | Today | | Google Search | Plaintext