Minetest logo

IRC log for #minetest-dev, 2017-08-19

| Channels | #minetest-dev index | Today | | Google Search | Plaintext

All times shown according to UTC.

Time Nick Message
00:29 Tmanyo joined #minetest-dev
01:25 KaadmY Is anybody aware that pressing the up or down arrow while in the pause menu gives a hard seg fault in 0.4.16 stavble?
02:47 YuGiOhJCJ joined #minetest-dev
06:05 nerzhul joined #minetest-dev
06:06 nerzhul hello
06:06 nerzhul merging #6277
06:06 ShadowBot https://github.com/minetest/minetest/issues/6277 -- Banmanager: Move 'creating' message from warningstream to infostream by paramat
07:10 YuGiOhJCJ joined #minetest-dev
07:12 nerzhul hello, i push a daily code modernization patch
07:15 Krock joined #minetest-dev
07:16 Krock heh nerzhul. You ninja'd me in pushing the ItemCAO removal branch :3
07:17 nerzhul heh feel free to merge the PR then :p
07:17 Hunterz joined #minetest-dev
07:21 nerzhul is the PR okay for you to merge ? :)
07:22 nerzhul !tell paramat there is a strange thing in mapgen v6 reported by clang-tidy, look at mapgen_v6.cpp L517, we do * (blockpos_max.Z - blockpos_max.Z + 1); on other axis we do * (blockpos_max.Y - blockpos_min.Y + 1) can you verify it's correct or is this a historical typo on v6
07:22 ShadowBot nerzhul: O.K.
07:26 Krock lol. max - max
07:27 nerzhul it's strange yes
07:27 nerzhul the variable affected is called volume
07:27 nerzhul then it's very very strange
07:29 Krock I can't see where this variable is used
07:29 nerzhul maybe it's unused, i just read the calculation, not the context :)
07:29 nerzhul pushing the second part of previous commit
07:30 nerzhul and merging #6279
07:30 ShadowBot https://github.com/minetest/minetest/issues/6279 -- ItemCAO removal by nerzhul
07:31 nerzhul volume_nodes = volume_blocks *
07:31 nerzhul MAP_BLOCKSIZE * MAP_BLOCKSIZE * MAP_BLOCKSIZE;
07:31 nerzhul and volume_nodes it's unused yes
07:31 nerzhul lol
07:31 nerzhul hopefully
07:31 nerzhul i think this part should be removed
07:31 nerzhul this will speedup a little bit the mapgen process on v6
07:32 nerzhul 21 jan 2013 is the introduction commit for this mapgen
08:08 fwhcat joined #minetest-dev
09:26 nerzhul merging #6274 & #6280 in ~ 5 mins
09:26 ShadowBot https://github.com/minetest/minetest/issues/6274 -- ServerMap saving: cleanups by nerzhul
09:26 ShadowBot https://github.com/minetest/minetest/issues/6280 -- Code modernization: src/n*, src/o* by nerzhul
09:28 nerzhul + 6281
09:31 nerzhul done
09:32 nerzhul i hope at a point the mac osx build will be fixed and succeed :(
09:36 Fritigern joined #minetest-dev
09:36 Fritigern_ joined #minetest-dev
09:36 Fritigern__ joined #minetest-dev
10:49 lisac joined #minetest-dev
11:15 Fixer joined #minetest-dev
11:47 Taoki[laptop] joined #minetest-dev
11:58 lisac joined #minetest-dev
12:05 DI3HARD139 joined #minetest-dev
12:18 nerzhul merging #6282 in ~ 5 mins
12:18 ShadowBot https://github.com/minetest/minetest/issues/6282 -- Code modernization: src/p*, src/q*, src/r*, src/s* (partial) by nerzhul
13:03 Beton joined #minetest-dev
13:05 lisac joined #minetest-dev
13:32 Lymkwi joined #minetest-dev
13:52 Taoki[mobile] joined #minetest-dev
13:59 Beton_ joined #minetest-dev
14:42 Raven262 joined #minetest-dev
16:08 paramat joined #minetest-dev
16:10 paramat yes that 'volume nodes' is a typo, but looks to be unused anywhere, i'll remove it if so. there's a 2nd 'volume nodes' in 'generate caves' but it's local and a different calculation
16:14 YuGiOhJCJ joined #minetest-dev
16:15 lisac joined #minetest-dev
16:51 paramat Krock rubenwardy sfan5 please could you look at #6273 ? tested and fairly simple
16:51 ShadowBot https://github.com/minetest/minetest/issues/6273 -- Minimap: Add new HUD flag for minimap radar mode by paramat
16:51 sfan5 sure
16:52 kaeza joined #minetest-dev
16:56 Krock lgtm
16:58 rubenwardy edited review
17:01 Warr1024 joined #minetest-dev
17:05 paramat thanks i'll check that situation and make it more robust
17:09 paramat i won't be here for meeting, but back later
17:11 sfan5 paramat: shouldn't it be named minimap_radar from the lua side
17:11 sfan5 otherwise lgtm
17:22 paramat yes possibly, i kept it short because all the other lua words were one word, but maybe consistency is better
17:23 paramat i'll attend to rubens issues
17:24 Beton__ joined #minetest-dev
18:02 nerzhul joined #minetest-dev
18:19 lisac joined #minetest-dev
18:50 Lymkwi joined #minetest-dev
19:00 Beton_ joined #minetest-dev
19:05 Krock rubenwardy, follow up question on your meta field PR: how does one clear a meta field?
19:05 Krock perhaps they never were removed, once created
19:13 rubenwardy I believe you can pass in nil
19:13 rubenwardy need to check
19:36 Beton__ joined #minetest-dev
19:58 bigfoot547 joined #minetest-dev
19:59 bigfoot547 Hey all
20:15 paramat joined #minetest-dev
20:17 nerzhul joined #minetest-dev
20:23 nerzhul merging #6283 and fixing one include place in game.cpp
20:23 ShadowBot https://github.com/minetest/minetest/issues/6283 -- Code modernization: subfolders by nerzhul
20:29 paramat thanks so much for all this cleanup work
20:38 paramat sofar an easy one for you game#1835
20:38 ShadowBot https://github.com/minetest​/minetest_game/issues/1835 -- Expose open_chests and chest_lid_obstructed by ForbiddenJ
20:41 Fixer btw on 2011 maps chest formspec is opened two times, instantly and later
20:44 nerzhul paramat, it's nearly complete hopefully
20:44 nerzhul it's just code modernize, but the for range based loops permits to have cleaner and safer loops in many place it's nice :)
20:46 paramat because 0.5 is coming i'm doing lots of cleanup in mapgen, those small jobs that got forgotten etc.
20:46 paramat i'll remove that 'volume nodes' from mgv6
20:46 nerzhul we have time release is not now and we need nice features
20:46 nerzhul yes it's not used and there is a calculation error :p
20:47 paramat yeah
20:48 paramat anyone +1 for game#1860 ? i suggest y = pos.y - 1 instead though, i could alter that on merge?
20:48 ShadowBot https://github.com/minetest​/minetest_game/issues/1860 -- Flowers: Optimize mushroom spread by tenplus1
20:49 paramat when is the migration of player backend, 0.5? my #6278 may be pointless
20:49 ShadowBot https://github.com/minetest/minetest/issues/6278 -- Player backend: Edit migration message to be less worrying by paramat
20:55 nerzhul yes if i correctly remembered we will switch default to sqlite
20:55 nerzhul (for new worlds only)
20:55 nerzhul and keep the warning for old worlds
20:56 nerzhul i think it can be time to do this just after switch to the new version model
21:07 paramat hmm so there's no auto-migration for old worlds? my PR may be innaccurate
21:10 nerzhul no auto migrate
21:10 nerzhul it's manual migration
21:11 nerzhul nice i finished the cleanup, i'm re-running clang-tidy on all our files to see if there were some missing issues to fix, it will take a lot of time :p
21:12 paramat ok
21:12 nerzhul we can force automigration if needed at a point, first just change the default
21:12 nerzhul it will remove the warning for new worlds
21:39 Taoki[laptop] joined #minetest-dev
22:04 nerzhul the last cleanup patchset is out #6285 after merge i will stop breaking recent PR heh
22:04 ShadowBot https://github.com/minetest/minetest/issues/6285 -- Modernize source code: last part by nerzhul
22:05 nerzhul i think i will try to add clang-tidy to the LINT permitting to trigger errors if the code quality is reduced in some PR, it's better if it's automated
22:05 nerzhul for the loops, the empty(), emplace_back() and some other tests it's very useful to fix them directly
22:39 paramat rubenwardy #6273 updated, all points addressed, will merge later tonight if no objection
22:40 ShadowBot https://github.com/minetest/minetest/issues/6273 -- Minimap: Add new HUD flag for minimap radar mode by paramat
22:40 rubenwardy have you checked that setting the flag when radar is open closes it?
22:46 paramat yes
22:47 paramat well, closes on next press of F9
22:47 paramat it doesn't seem possible to force-exit minimap when the flag is set
22:48 paramat hmm
22:48 paramat a player could then just stay in the current radar mode
22:49 paramat well, can we work on this in another PR?
22:50 paramat but then ..
22:50 paramat setting the minimap flag to false force-exits
22:50 paramat so there might be a way, i'll check
23:00 paramat yeah it's probably possible, will work on it
23:07 proller joined #minetest-dev
23:29 paramat yes i can do this
23:43 fwhcat joined #minetest-dev

| Channels | #minetest-dev index | Today | | Google Search | Plaintext